Label Components - #5540
Merged
Merged
Conversation
greenbonebot
enabled auto-merge (rebase)
August 18, 2026 13:24
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5540 +/- ##
=======================================
Coverage 84.11% 84.11%
=======================================
Files 1294 1294
Lines 33775 33780 +5
Branches 10062 10060 -2
=======================================
+ Hits 28409 28414 +5
Misses 4816 4816
Partials 550 550 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bjoernricks
force-pushed
the
label-components
branch
2 times, most recently
from
August 19, 2026 09:20
4f898ce to
a37cbbe
Compare
daniele-mng
approved these changes
Aug 19, 2026
Use same name as the object of the default export. Also improve its tests.
Ensure the function behaves as expected.
Make comparing colors more prone against the actual implementation by converting the css color to the computed style color.
Use same name as the object exported as the default export. Also add tests for the module.
Improve the module and add tests too.
Use PascalCase naming for components and modules.
bjoernricks
force-pushed
the
label-components
branch
from
August 19, 2026 09:45
a37cbbe to
5343cff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Improve Label components
Why
Have tests for all components in
web/components🥳Checklist