Change: allow editing a target that a task refers to - #5541
Closed
TheBeast85 wants to merge 1 commit into
Closed
Conversation
The target dialog disabled hosts, port list and every credential once the target was in use, and Target.save then sent only name, comment and alive tests. The scan target of a task could not be corrected from the interface. gvmd no longer refuses those changes, so the dialog does not have to guess. Drop the inUse gating and send the whole form again.
greenbonebot
enabled auto-merge (rebase)
August 18, 2026 21:16
Contributor
|
Hi, this PR will not be applied. The in use feature is an important concept in our software and removing it has several consequences. Therefore I'll close this PR. @TheBeast85 please create issues for such big changes first and discuss the possibility of getting the desired changes into the software before creating a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop the
inUsehandling from the target dialog. The fields are no longer disabled, andhandleSaveClickno longer reduces the request to name, comment and alive tests.Why
Once a task referred to a target, the dialog disabled hosts, port list and every credential, so the scan target of a task could not be corrected here. That mirrored a restriction in gvmd which greenbone/gvmd#3098 removes; with it gone the dialog no longer has to anticipate what gvmd will accept, and any remaining error comes back from gvmd.
Testing
The existing target tests, with the case that asserted the fields are disabled for a target in use turned around to assert they stay editable.
References
Needs greenbone/gvmd#3098.