Removed hosts_ordering from gmp_create_task_ext ( ... ). #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
bjoernricks
reviewed
Jan 22, 2026
Contributor
bjoernricks
left a comment
bjoernricks
left a comment
There was a problem hiding this comment.
Hi, i don't think we should change gmp_create_task_opts_t because it breaks the API and ABI. It is fine to remove the hosts_ordering from the gmp_create_task_ext function because that has no influence on the API but changing a struct even breaks the ABI. This would require to increase the major version of the release and the .so binary.
bjoernricks
approved these changes
Jan 30, 2026
The hosts ordering option has never been used, so it is removed from the sources.
bjoernricks
force-pushed
the
GEA-1499_Remove_hosts_ordering_from_gvmd_gvm-libs_and_gsad
branch
from
7e8bb9e to
7b8aed1
Compare
bjoernricks
deleted the
GEA-1499_Remove_hosts_ordering_from_gvmd_gvm-libs_and_gsad
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The hosts ordering option has never been used, so it is removed from the sources.
Why
The hosts ordering option was never used.
References
GEA-1499
Checklist