Skip to content

Conversation

@mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Jan 22, 2026

What

Use the same format for the header guards in .h files: #ifndef _GVM_<DIRNAME>_<FILENAME>

Why

  1. It's neater
  2. It's easier to understand what to use for new files.
  3. It may prevent clashes with headers from other libraries.
  4. It may prevent clashes when there are files with the same name in multiple dirs.

Testing

Compiles fine.

@mattmundell mattmundell requested review from a team as code owners January 22, 2026 13:50
@greenbonebot greenbonebot enabled auto-merge (rebase) January 22, 2026 13:50
@github-actions
Copy link

github-actions bot commented Jan 22, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 2592a88.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@greenbonebot greenbonebot merged commit d2d0687 into main Jan 26, 2026
18 checks passed
@greenbonebot greenbonebot deleted the unify-guards branch January 26, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants