Fixed some frontend issues #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces both a critical logical error in API key migration handling and adds new node graph interaction capabilities.
- Critical bug in
/public/app/features/api-keys/ApiKeysPage.tsx: Changed conditionfailedApikeyIDs.length !== 0to>= 0causing failed migration details to always display - Added double-click support in
/public/app/plugins/panel/nodeGraph/Node.tsxthrough new optional handler prop - Modified mainStatValue index calculation in Node.tsx to use
index + 1which may affect data display - Removed redundant x/y coordinate check in NodeContents component
- Improved error messaging for API key migration failures with more detailed status information
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -189,7 +189,7 @@ export const MigrationSummary: React.FC<MigrationSummaryProps> = ({ visible, dat | |||
| </p> | |||
| </div> | |||
| )} | |||
| {data.failedApikeyIDs.length !== 0 && ( | |||
| {data.failedApikeyIDs.length >= 0 && ( | |||
There was a problem hiding this comment.
logic: This condition will always be true since array lengths cannot be negative. Should remain !== 0 to only show failure details when there are actual failures.
| if (!(node.x !== undefined && node.y !== undefined)) { | ||
| return null; | ||
| } | ||
| const mainStatValue = node.mainStat?.values[node.dataFrameRowIndex + 1]; |
There was a problem hiding this comment.
logic: Accessing index + 1 could cause array bounds issues if mainStat.values array length matches dataFrameRowIndex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.