Optional configuration override for taskwarrior filters #2174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bim9262
reviewed
Aug 14, 2025
| @@ -166,4 +185,6 @@ async fn get_number_of_tasks(filter: &str) -> Result<u32> { | |||
| pub struct Filter { | |||
| pub name: String, | |||
| pub filter: String, | |||
| #[serde(default)] | |||
There was a problem hiding this comment.
pr looks good, one small nit is that you don't need #[serde(default)] here since the struct is already #[derive(Default)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds an optional field to taswarrior's filter configuration that allows to specify configuration overrides for taskwarrior on per-filter basis. I mostly use it to work with contexts: when i change the context in taskwarrior it affects my filters in i3status, but since it can be used in other cases too (like #2071) i decided to add a general configuration override instead of specific context setting.