Skip to content

Conversation

hannesdiedrich
Copy link
Member

… storages parameters too

Reason for the proposed changes

Please describe what we want to achieve and why.

Proposed changes

GSY_WEB_BRANCH=master

Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.38%. Comparing base (a9c1b67) to head (3f916c4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   67.37%   67.38%   +0.01%     
==========================================
  Files          87       87              
  Lines        5486     5510      +24     
  Branches     1242     1249       +7     
==========================================
+ Hits         3696     3713      +17     
- Misses       1616     1621       +5     
- Partials      174      176       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@spyrostz spyrostz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@spyrostz spyrostz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even though that for the connection with gsy-web you also need to modify the AVRO schemas of the heat pump. This can be done later though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants