-
Notifications
You must be signed in to change notification settings - Fork 6
Improve lf parameters layout #1237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
b90548f
3c8a238
52b5b73
dd31d3d
f85761a
6332489
372db36
dfe12f2
781ec5e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| /** | ||
| * Copyright (c) 2026, RTE (http://www.rte-france.com) | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
| */ | ||
|
|
||
| import { memo } from 'react'; | ||
| import ParameterField from '../common/parameter-field'; | ||
| import { | ||
| DC_POWER_FACTOR, | ||
| DC_USE_TRANSFORMER_RATIO, | ||
| DISTRIBUTED_SLACK, | ||
| READ_SLACK_BUS, | ||
| SHUNT_COMPENSATOR_VOLTAGE_CONTROL_ON, | ||
| TWT_SPLIT_SHUNT_ADMITTANCE, | ||
| USE_REACTIVE_LIMITS, | ||
| VOLTAGE_INIT_MODE, | ||
| WRITE_SLACK_BUS, | ||
| } from './constants'; | ||
| import { ParameterType, SpecificParameterInfos } from '../../../utils/types/parameters.type'; | ||
| import { ADVANCED_PARAMETERS } from '../common'; | ||
|
|
||
| export const advancedParams: SpecificParameterInfos[] = [ | ||
| { | ||
| name: VOLTAGE_INIT_MODE, | ||
| type: ParameterType.STRING, | ||
| label: 'descLfVoltageInitMode', | ||
| possibleValues: [ | ||
| { | ||
| id: 'UNIFORM_VALUES', | ||
| label: 'descLfUniformValues', | ||
| }, | ||
| { | ||
| id: 'PREVIOUS_VALUES', | ||
| label: 'descLfPreviousValues', | ||
| }, | ||
| { | ||
| id: 'DC_VALUES', | ||
| label: 'descLfDcValues', | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| name: USE_REACTIVE_LIMITS, | ||
| type: ParameterType.BOOLEAN, | ||
| label: 'descLfUseReactiveLimits', | ||
| }, | ||
| { | ||
| name: TWT_SPLIT_SHUNT_ADMITTANCE, | ||
| type: ParameterType.BOOLEAN, | ||
| label: 'descLfTwtSplitShuntAdmittance', | ||
| }, | ||
| { | ||
| name: READ_SLACK_BUS, | ||
| type: ParameterType.BOOLEAN, | ||
| label: 'descLfReadSlackBus', | ||
| }, | ||
| { | ||
| name: WRITE_SLACK_BUS, | ||
| type: ParameterType.BOOLEAN, | ||
| label: 'descLfWriteSlackBus', | ||
| }, | ||
| { | ||
| name: DISTRIBUTED_SLACK, | ||
| type: ParameterType.BOOLEAN, | ||
| label: 'descLfDistributedSlack', | ||
| }, | ||
| { | ||
| name: SHUNT_COMPENSATOR_VOLTAGE_CONTROL_ON, | ||
| type: ParameterType.BOOLEAN, | ||
| label: 'descLfShuntCompensatorVoltageControlOn', | ||
| }, | ||
| { | ||
| name: DC_USE_TRANSFORMER_RATIO, | ||
| type: ParameterType.BOOLEAN, | ||
| label: 'descLfDcUseTransformerRatio', | ||
| }, | ||
| { | ||
| name: DC_POWER_FACTOR, | ||
| type: ParameterType.DOUBLE, | ||
| label: 'descLfDcPowerFactor', | ||
| }, | ||
| ]; | ||
|
|
||
| function LoadFlowAdvancedParameters() { | ||
| return ( | ||
| <> | ||
| {advancedParams.map((item) => ( | ||
| <ParameterField id={ADVANCED_PARAMETERS} {...item} key={item.name} /> | ||
| ))} | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| export default memo(LoadFlowAdvancedParameters); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,6 +35,7 @@ export function LoadFlowParametersForm({ loadflowMethods }: Readonly<LoadFlowPar | |
| handleTabChange={handleTabChange} | ||
| tabIndexesWithError={tabIndexesWithError} | ||
| formattedProviders={formattedProviders} | ||
| disableSpecificProviderParams={!watchProvider || !specificParametersDescriptionForProvider} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure why we need that?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. before, the specific provider params section was disabled when no provider value is set or a failure when fetching the provider params , so here we have the same bihaviour of disabling the Tab |
||
| /> | ||
| </Grid> | ||
| <Grid size={12}> | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.