Skip to content

feat: add optional references field to ElementAttributes - #1246

Merged
flomillot merged 5 commits into
mainfrom
florent/GRD-4774-add-references-to-element-attributes
Aug 4, 2026
Merged

feat: add optional references field to ElementAttributes#1246
flomillot merged 5 commits into
mainfrom
florent/GRD-4774-add-references-to-element-attributes

Conversation

@flomillot

Copy link
Copy Markdown
Contributor

Expose the references of an element on ElementAttributes, along with the ReferenceAttributes type and the ReferenceType enum.

A shared element carries the list of its uses as references. Applications need them to tell whether an element is shared, and to list the elements using it.

Required by gridsuite/gridexplore-app#895.

Shared elements carry the list of their uses as references. Expose them
on ElementAttributes so applications can tell whether an element is
shared and list the elements using it.

Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f12c2f0d-8cf8-4328-b882-e23d67cc5c45

📥 Commits

Reviewing files that changed from the base of the PR and between 4d909a3 and cba8494.

📒 Files selected for processing (1)
  • src/utils/types/types.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/utils/types/types.ts

📝 Walkthrough

Walkthrough

Changes

Directory reference modeling

Layer / File(s) Summary
Reference contracts
src/utils/types/types.ts
Adds the ReferenceType enum and ReferenceAttributes type. Extends ElementAttributes with optional typed references.

Suggested reviewers: antoinebhs, ayolab, themaskedturtle

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding an optional references field to ElementAttributes.
Description check ✅ Passed The description directly explains the new references field, related types, purpose, and dependency.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…to-element-attributes' into florent/GRD-4774-add-references-to-element-attributes
Comment thread src/utils/types/types.ts
Comment thread src/utils/types/types.ts
Comment thread src/utils/types/types.ts
@flomillot
flomillot requested a review from ghazwarhili August 3, 2026 11:01
…references-to-element-attributes

# Conflicts:
#	src/utils/types/types.ts
@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2026

Copy link
Copy Markdown

@flomillot
flomillot merged commit 5000cd8 into main Aug 4, 2026
6 checks passed
@flomillot
flomillot deleted the florent/GRD-4774-add-references-to-element-attributes branch August 4, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants