Skip to content

use universal usetabs hook - #1307

Merged
khouadrired merged 14 commits into
mainfrom
use-universal-usetabs-hook
Sep 1, 2026
Merged

use universal usetabs hook#1307
khouadrired merged 14 commits into
mainfrom
use-universal-usetabs-hook

Conversation

@khouadrired

@khouadrired khouadrired commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Your free Security trial is over. An organization admin can activate billing to continue.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 0dc83be6-f010-49c4-8a6b-befaf4bb6a57

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@khouadrired khouadrired mentioned this pull request Aug 24, 2026
Merged
@khouadrired
khouadrired requested a review from thangqp August 26, 2026 12:50
thangqp
thangqp reviewed Aug 27, 2026
View reviewed changes
Comment thread src/features/parameters/dynamic-margin-calculation/dynamic-margin-calculation-inline.tsx Outdated
Comment thread src/features/parameters/dynamic-security-analysis/dynamic-security-analysis-inline.tsx Outdated
Comment thread src/features/parameters/dynamic-simulation/dynamic-simulation-inline.tsx Outdated
Comment thread src/features/parameters/loadflow/use-load-flow-parameters-form.ts Outdated
Comment thread src/features/parameters/network-visualizations/use-network-visualizations-parameters-form.ts Outdated
Comment thread src/features/parameters/security-analysis/use-security-analysis-parameters-form.ts Outdated
Comment thread src/features/parameters/sensi/sensitivity-parameters-selector.tsx Outdated
Comment thread src/features/parameters/sensi/sensitivity-parameters-selector.tsx Outdated
Comment thread src/features/parameters/short-circuit/use-short-circuit-parameters-form.ts Outdated
Comment thread src/features/parameters/voltage-init/use-voltage-init-parameters-form.ts Outdated
@thangqp thangqp added the waiting-for-review PR ready for an owner to review label Aug 28, 2026
@TheMaskedTurtle TheMaskedTurtle removed the waiting-for-review PR ready for an owner to review label Sep 1, 2026
@TheMaskedTurtle TheMaskedTurtle self-assigned this Sep 1, 2026
TheMaskedTurtle
TheMaskedTurtle approved these changes Sep 1, 2026
View reviewed changes

@TheMaskedTurtle TheMaskedTurtle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but agreed on the principle of migration after discussion with Redouane and Thang

thangqp
thangqp reviewed Sep 1, 2026
View reviewed changes
Comment thread src/features/parameters/sensi/use-sensitivity-analysis-parameters.ts Outdated
@thangqp

thangqp commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Not tested but agreed on the principle of migration after discussion with Redouane and Thang

@TheMaskedTurtle

In Explore, and also in Study, a lot of hypothesis of modification type not yet use useTabs (for example, Generator modification, which has field positive, etc.)

It should create a ticket use useTabs also for modification type (and creation type if not yet) for composition in Explore and modification in Study.

@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khouadrired
khouadrired merged commit 005d3d4 into main Sep 1, 2026
6 checks passed
@khouadrired
khouadrired deleted the use-universal-usetabs-hook branch September 1, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thangqp thangqp thangqp approved these changes
@TheMaskedTurtle TheMaskedTurtle TheMaskedTurtle approved these changes
@klesaulnier klesaulnier Awaiting requested review from klesaulnier klesaulnier is a code owner
@ayolab ayolab Awaiting requested review from ayolab ayolab is a code owner
@flomillot flomillot Awaiting requested review from flomillot flomillot is a code owner
@antoinebhs antoinebhs Awaiting requested review from antoinebhs antoinebhs is a code owner

Assignees

@TheMaskedTurtle TheMaskedTurtle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khouadrired @thangqp @TheMaskedTurtle