Skip to content

chore(TwoWindingsTransformerCreation): use form from commons-UI - #939

Merged
dbraquart merged 10 commits into
mainfrom
dbraquart/use-2wt-creation-form-from-commons-UI
Aug 20, 2026
Merged

chore(TwoWindingsTransformerCreation): use form from commons-UI#939
dbraquart merged 10 commits into
mainfrom
dbraquart/use-2wt-creation-form-from-commons-UI

Conversation

@dbraquart

@dbraquart dbraquart commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

PR Summary

TwoWindingsTransformerCreation form is now supported in composite modifications dialog. Requires gridsuite/commons-ui#1294.

Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 26b2bb37-0a07-46f4-b22d-7f268200b986

📝 Walkthrough

Walkthrough

The composite modification dialog now supports two-windings transformer creation. The modification dialog accepts an optional breakpoint width and passes it to CustomMuiDialog.

Changes

Two-windings transformer creation

Layer / File(s) Summary
Configurable modification dialog width
src/components/dialogs/network-modification/simple-modification/ModificationDialog.tsx, src/components/dialogs/network-modification/composite-modification/composite-modification-dialog.tsx
ModificationDialog accepts an optional dialogWidth breakpoint and passes it to CustomMuiDialog. The composite dialog configuration supports this property.
Composite dialog creation wiring
src/components/dialogs/network-modification/composite-modification/composite-modification-dialog.tsx
The dialog imports and registers the two-windings transformer creation form, schema, and DTO conversion functions. It adds the creation identifiers, settings, and XL dialog width.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: using the commons-UI form for TwoWindingsTransformerCreation.
Description check ✅ Passed The description accurately states that TwoWindingsTransformerCreation is supported in the composite modifications dialog.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/components/dialogs/network-modification/composite-modification/composite-modification-dialog.tsx`:
- Around line 232-244: Add the missing TwoWindingsTransformerCreationError and
CreateTwoWindingsTransformer localization keys to the app’s translation
catalogs, ensuring the existing errorHeaderId and titleId references in the
composite modification configuration resolve to translated messages.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cdd3cd9b-8efa-4594-8cb7-8178b5259b56

📥 Commits

Reviewing files that changed from the base of the PR and between 8cce03c and d066011.

📒 Files selected for processing (1)
  • src/components/dialogs/network-modification/composite-modification/composite-modification-dialog.tsx

…ation-form-from-commons-UI

# Conflicts:
#	src/components/dialogs/network-modification/composite-modification/composite-modification-dialog.tsx

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/components/dialogs/network-modification/simple-modification/ModificationDialog.tsx`:
- Around line 107-109: Update ModificationDialog’s width props and
.MuiDialog-paper minWidth styling to apply only when dialogWidth is provided;
preserve the existing default dialog sizing when it is omitted, including
transformer-creation dialogs. Then verify desktop layouts for legacy dialogs
that still use the base dialog style.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b72b409a-5d7c-4961-9ae3-18e543c30d98

📥 Commits

Reviewing files that changed from the base of the PR and between 79a3720 and 73238bc.

📒 Files selected for processing (2)
  • src/components/dialogs/network-modification/composite-modification/composite-modification-dialog.tsx
  • src/components/dialogs/network-modification/simple-modification/ModificationDialog.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/dialogs/network-modification/composite-modification/composite-modification-dialog.tsx

Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
@dbraquart
dbraquart force-pushed the dbraquart/use-2wt-creation-form-from-commons-UI branch from 26ca497 to 3191c17 Compare August 10, 2026 11:18
dbraquart and others added 3 commits August 11, 2026 18:05
…ation-form-from-commons-UI

# Conflicts:
#	src/components/dialogs/network-modification/composite-modification/composite-modification-dialog.tsx
#	src/components/dialogs/network-modification/simple-modification/ModificationDialog.tsx
@sonarqubecloud

Copy link
Copy Markdown

@dbraquart
dbraquart merged commit bb47633 into main Aug 20, 2026
6 checks passed
@dbraquart
dbraquart deleted the dbraquart/use-2wt-creation-form-from-commons-UI branch August 20, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants