chore(TwoWindingsTransformerCreation): use form from commons-UI - #939
Conversation
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📝 WalkthroughWalkthroughThe composite modification dialog now supports two-windings transformer creation. The modification dialog accepts an optional breakpoint width and passes it to ChangesTwo-windings transformer creation
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/components/dialogs/network-modification/composite-modification/composite-modification-dialog.tsx`:
- Around line 232-244: Add the missing TwoWindingsTransformerCreationError and
CreateTwoWindingsTransformer localization keys to the app’s translation
catalogs, ensuring the existing errorHeaderId and titleId references in the
composite modification configuration resolve to translated messages.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: cdd3cd9b-8efa-4594-8cb7-8178b5259b56
📒 Files selected for processing (1)
src/components/dialogs/network-modification/composite-modification/composite-modification-dialog.tsx
…ation-form-from-commons-UI # Conflicts: # src/components/dialogs/network-modification/composite-modification/composite-modification-dialog.tsx
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/components/dialogs/network-modification/simple-modification/ModificationDialog.tsx`:
- Around line 107-109: Update ModificationDialog’s width props and
.MuiDialog-paper minWidth styling to apply only when dialogWidth is provided;
preserve the existing default dialog sizing when it is omitted, including
transformer-creation dialogs. Then verify desktop layouts for legacy dialogs
that still use the base dialog style.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b72b409a-5d7c-4961-9ae3-18e543c30d98
📒 Files selected for processing (2)
src/components/dialogs/network-modification/composite-modification/composite-modification-dialog.tsxsrc/components/dialogs/network-modification/simple-modification/ModificationDialog.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
- src/components/dialogs/network-modification/composite-modification/composite-modification-dialog.tsx
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
26ca497 to
3191c17
Compare
…ation-form-from-commons-UI # Conflicts: # src/components/dialogs/network-modification/composite-modification/composite-modification-dialog.tsx # src/components/dialogs/network-modification/simple-modification/ModificationDialog.tsx
Signed-off-by: David BRAQUART <david.braquart@rte-france.com>
|



PR Summary
TwoWindingsTransformerCreation form is now supported in composite modifications dialog. Requires gridsuite/commons-ui#1294.