Warn about shared elements in the delete confirmation dialog - #958
Open
flomillot wants to merge 3 commits into
Open
Warn about shared elements in the delete confirmation dialog#958flomillot wants to merge 3 commits into
flomillot wants to merge 3 commits into
Conversation
Display the sharing links of the selected elements in the deletion confirmation, so that permanently deleting an element used elsewhere is not done unknowingly. A single selected element gets a plain sentence, a multiple selection gets the list of the shared elements with their number of sharing links. Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deleting an element still referenced elsewhere breaks the referencing elements, so the confirmation only informs about the sharing links and no longer allows the deletion. Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
|
ghazwarhili
self-requested a review
August 19, 2026 09:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting elements in GridExplore, the confirmation dialog now tells whether the selection contains elements shared with other elements, along with their number of sharing links.
An element is considered shared as soon as its
referencesarray is not empty, each reference being a sharing link — the same criterion as the "Display sharing links" contextual menu entry.The delete button is disabled as long as the selection holds a shared element, so a deletion that would break the referencing elements cannot be confirmed. Marked with a TODO, to be removed once the deletion of shared elements is handled.