Skip to content

onHighlightConsumed #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mathieu-Deharbe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

onHighlightConsumed #4061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/graph/menus/network-modifications/network-modification-node-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,6 +1163,7 @@
pendingState={pendingState}
columns={columns}
highlightedModificationUuid={highlightedModificationUuid}
onHighlightConsumed={() => dispatch(setHighlightModification(null))}

Check failure on line 1166 in src/components/graph/menus/network-modifications/network-modification-node-editor.tsx

View workflow job for this annotation

GitHub Actions / build / build 

Type '{ handleCellClick: (modification: NetworkModificationMetadata) => void; modifications: NetworkModificationMetadata[]; ... 19 more ...; isDisabled: boolean; }' is not assignable to type 'IntrinsicAttributes & Readonly<NetworkModificationsTableProps>'.

@flomillot flomillot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new ref at every rerender, not a big deal but if every other props are memoized, maybe wrap into usecallback

modificationUuidsToReset={modificationUuidsToReset}
modificationToEditLabel={modificationToEditLabel}
studyUuid={studyUuid}
Expand Down
Loading