Skip to content

Make a NAD voltage level label behave like its node #4118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flomillot wants to merge 5 commits into
base: main
Choose a base branch
from
+7 −1
Open

Make a NAD voltage level label behave like its node #4118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b837b0
Show a pointer cursor on a NAD voltage level label
flomillot Jul 30, 2026
781d964
Show the voltage level popover when hovering its NAD label
flomillot Aug 3, 2026
8b09b95
Reword the TEXT_NODE comment
flomillot Aug 3, 2026
1666208
Simplify TEXT_NODE comment in feederType.ts
flomillot Aug 3, 2026
0854b16
Merge branch 'main' into flomillot/nad-label-pointer-cursor
flomillot Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/grid-layout/cards/diagrams/diagram-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ export function getEquipmentTypeFromFeederType(feederType: FeederTypes | null):
case FEEDER_TYPES.THREE_WINDINGS_TRANSFORMER_LEG:
return { equipmentType: EquipmentType.THREE_WINDINGS_TRANSFORMER };
case FEEDER_TYPES.VOLTAGE_LEVEL:
case FEEDER_TYPES.TEXT_NODE: // a NAD label carries the id of the voltage level it labels
return { equipmentType: EquipmentType.VOLTAGE_LEVEL };
default: {
console.log('bad feeder type ', feederType);
Expand Down Expand Up @@ -122,6 +123,7 @@ export const equipmentsWithPopover = [
FEEDER_TYPES.TWO_WINDINGS_TRANSFORMER_LEG,
FEEDER_TYPES.LOAD,
FEEDER_TYPES.VOLTAGE_LEVEL,
FEEDER_TYPES.TEXT_NODE,
FEEDER_TYPES.GENERATOR,
];

Expand Down
4 changes: 4 additions & 0 deletions src/components/utils/feederType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,9 @@ export const FEEDER_TYPES = {
THREE_WINDINGS_TRANSFORMER_LEG: 'THREE_WINDINGS_TRANSFORMER_LEG',
HVDC_LINE_VSC: 'HVDC_LINE_VSC',
HVDC_LINE_LCC: 'HVDC_LINE_LCC',
/**
* it is the element type the NAD reports for the label of a voltage level
*/
TEXT_NODE: 'TEXT_NODE',
};
export type FeederTypes = ValueOf<typeof FEEDER_TYPES>;
2 changes: 1 addition & 1 deletion src/nad-index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
width: max-content;
padding: 10px;
border-radius: 10px;
cursor: default;
cursor: pointer;
border: 2px solid rgba(0,0,0,0);
}
.nad-legend-square {
Expand Down
Loading