Skip to content

actions , ref modif #4148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
souissimai wants to merge 12 commits into
base: main
Choose a base branch
from
Open

actions , ref modif #4148

Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e7c7ce7
actions , ref modif
Aug 13, 2026
586f8aa
Merge branch 'main' into reference-modification-actions
souissimai Aug 13, 2026
5261c3d
Merge branch 'main' into reference-modification-actions
souissimai Aug 14, 2026
58ea185
Merge branch 'main' into reference-modification-actions
Mathieu-Deharbe Aug 18, 2026
ada0d8e
Merge branch 'main' into reference-modification-actions
souissimai Aug 18, 2026
5998069
Merge branch 'main' into reference-modification-actions
souissimai Aug 19, 2026
911c229
remarks
Aug 19, 2026
fe29e1d
move copy a reference
Aug 21, 2026
b26084f
move copy a reference
Aug 21, 2026
e3fba5f
breaking changes
Aug 24, 2026
0e638b5
resolve conflicts
Aug 26, 2026
e2e1ea4
comments clean
Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 19 additions & 17 deletions src/components/graph/menus/network-modifications/network-modification-node-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
NetworkModificationMetadata,
NetworkModificationsTable,
NotificationsUrlKeys,
ReferenceModificationInfos,
removeNullFields,
setModificationMetadata,
snackWithFallback,
Expand Down Expand Up @@ -179,14 +180,6 @@ const NetworkModificationNodeEditor = () => {
[]
);

// TODO : this is temporary, until copy/paste/save is done for the shared modifications in GRD-4785 :
const selectionContainsShared: boolean = useMemo(() => {
return selectedNetworkModifications.some(
(modification: ComposedModificationMetadata) =>
modification.type === ModificationType.MODIFICATION_REFERENCE
);
}, [selectedNetworkModifications]);

Comment thread
Mathieu-Deharbe marked this conversation as resolved.
const [isDragging, setIsDragging] = useState(false);
const [isAssemblyDepthExceeded, setIsAssemblyDepthExceeded] = useState(false);

Expand Down Expand Up @@ -970,10 +963,21 @@ const NetworkModificationNodeEditor = () => {
folderName,
folderId,
}: IElementCreationDialog) => {
const selectedModificationsUuid = selectedNetworkModifications.map((item) => item.uuid);

setSaveInProgress(true);
createCompositeModifications(name, description, folderId, selectedModificationsUuid)

Promise.all(
selectedNetworkModifications.map((item) =>
item.type === MODIFICATION_TYPES.MODIFICATION_REFERENCE.type
? fetchNetworkModification(item.uuid as UUID)
.then((res) => res.json())
.then((detail: ReferenceModificationInfos) => detail.referenceId ?? null)
: Promise.resolve(item.uuid)
)
)
.then((uuids) => uuids.filter((uuid): uuid is UUID => uuid !== null))
Comment thread
Mathieu-Deharbe marked this conversation as resolved.
Outdated
.then((selectedModificationsUuid) =>
createCompositeModifications(name, description, folderId, selectedModificationsUuid)
)
Comment thread
Mathieu-Deharbe marked this conversation as resolved.
.then(() => {
snackInfo({
headerId: 'infoCreateModificationsMsg',
Expand Down Expand Up @@ -1325,7 +1329,7 @@ const NetworkModificationNodeEditor = () => {
<IconButton
onClick={openCreateCompositeModificationDialog}
size={'small'}
disabled={disabledCompositeExport || selectionContainsShared}
disabled={disabledCompositeExport}
>
<SaveIcon />
</IconButton>
Expand All @@ -1341,8 +1345,7 @@ const NetworkModificationNodeEditor = () => {
isAnyNodeBuilding ||
mapDataLoading ||
!currentNode ||
isRootNode ||
selectionContainsShared
isRootNode
}
>
<ContentCutIcon />
Expand All @@ -1358,8 +1361,7 @@ const NetworkModificationNodeEditor = () => {
selectedNetworkModifications.length === 0 ||
isAnyNodeBuilding ||
mapDataLoading ||
isRootNode ||
selectionContainsShared
isRootNode
}
>
<ContentCopyIcon />
Expand All @@ -1381,7 +1383,7 @@ const NetworkModificationNodeEditor = () => {
<IconButton
onClick={doPasteModifications}
size={'small'}
disabled={isPasteButtonDisabled || isRootNode || selectionContainsShared}
disabled={isPasteButtonDisabled || isRootNode}
>
<ContentPasteIcon />
</IconButton>
Expand Down
Loading