Skip to content

remove calculation data from spreadsheet copy #4160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EtienneLt wants to merge 3 commits into
base: main
Choose a base branch
from
Open

remove calculation data from spreadsheet copy #4160

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75bb370
remove calculation data from spreadsheet copy
EtienneLt Aug 21, 2026
de35f10
Merge branch 'main' into remove-calculation-from-spreadsheet-copy
EtienneLt Aug 21, 2026
7b6e9d7
sonar
EtienneLt Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions ...ponents/spreadsheet-view/spreadsheet/spreadsheet-toolbar/save/save-spreadsheet-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,21 @@ export default function SaveSpreadsheetButton({

const getCsvProps = useCallback(
(csvCase: SpreadsheetSaveOptionId.COPY_CSV | SpreadsheetSaveOptionId.EXPORT_CSV) => {
const gridCsvFunction =
csvCase === SpreadsheetSaveOptionId.COPY_CSV
? gridRef.current?.api.getDataAsCsv
: gridRef.current?.api.exportDataAsCsv;
const isCopy = csvCase === SpreadsheetSaveOptionId.COPY_CSV;
const gridCsvFunction = (params?: any) => {

@ghazwarhili ghazwarhili Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess the type here (params?: ValueGetterParams)

const exportParams = {
...params,
shouldRowBeSkipped: (rowParams: any) => {

@ghazwarhili ghazwarhili Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(owParams: ShouldRowBeSkippedParams)

const rowData: { rowType?: string } = rowParams.node?.data;
// remove lines used to calculate
return rowData?.rowType?.includes('calculation');
},
};

return isCopy

@ghazwarhili ghazwarhili Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to define cont varaiable isCopy, you can used directly like
csvCase === SpreadsheetSaveOptionId.COPY_CSV ?
gridRef.current?.api.getDataAsCsv(exportParams)
: gridRef.current?.api.exportDataAsCsv(exportParams);

? gridRef.current?.api.getDataAsCsv(exportParams)
: gridRef.current?.api.exportDataAsCsv(exportParams);
};
if (!gridCsvFunction) {
console.error('Csv API is not available.');
return;
Expand Down
Loading