-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEA-298 Extend protocol to update sw (with grisp_updater) #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check #40 |
ziopio
force-pushed
the
SEA-298/extend-protocol-to-update-sw
branch
from
September 24, 2024 13:57
3d4aad7
to
a9a2364
Compare
matlaj
reviewed
Sep 25, 2024
ziopio
force-pushed
the
main
branch
3 times, most recently
from
September 26, 2024 07:38
80cfc5d
to
499da87
Compare
IciaCarroBarallobre
force-pushed
the
SEA-298/extend-protocol-to-update-sw
branch
from
September 27, 2024 14:55
3b02a9b
to
52eaf21
Compare
sylane
reviewed
Oct 1, 2024
ziopio
requested changes
Oct 4, 2024
ziopio
reviewed
Oct 4, 2024
* Do not loop on sync calls to WS while waiting for a connection This allows to instantly detect a connection * Support sending of jsonrpc notifications * Use new notification to report download progress
…nt notifications.
* Handle boot_system_not_validated * Add validate method
ziopio
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! just check comment
ziopio
approved these changes
Oct 10, 2024
sylane
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
Get partition state local test
Improvement and other ideas
Here are some insights and suggestions I encountered while developing:
In seawater config highlight the different names of the cert (CA.pem & .pem files).
When
rebar3 grisp pack
- When packing a release, a green test instruction is displayed for non-rebar3 grisp-io plugin users. It could potentially distract users who don’t intend to perform the pack manually. Maybe we can write a warning.Integrating all docu related to setup local dev, maybe in confluence:
-> 1) Ask for sys.config seawater env vars (api_key & password)
-> 2) Seawater create an account and add a subscription
--> 2,1) Explain subscription for testing in Seawater (and that you could use any token for subscription)
-> 3) Set up locally grisp_connect under grisp_project/_checkout/ with seawater
--> 3,1) Specify in 0 step where, like create a grisp project, and under _checkouts of grisp board project clone the necessary repos (like grisp_connect, rebar3_grisp, rebar3_grisp_io, grisp_updater_grisp2, etc).
Clarify persistent updates: Updates are stored persistently in memory, meaning users need to remove the SD card to boot from the partition. To avoid users restarting using removable.
Future idea)
rebar3 configure --exisiting_project=<folder>
just for things like integrate network a posteriori or Wi-Fi.