When running behind another proxy, need to tell traefik to trust its X-Forwarded-* headers #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…X-Forwarded-* headers
paulfitz
reviewed
Jan 10, 2024
README.md
Outdated
| @@ -100,6 +100,12 @@ docker run \ | |||
| Remember if you are on a public server you don't need to do this, you can | |||
| set `HTTPS=auto` and have Traefik + Let's Encrypt do the work for you. | |||
|
|
|||
| If you run the omnibus behind a separate reverse proxy that terminates SSL, then you should | |||
| `HTTPS=external`, and set an additional environment variable `TRUSTED_PROXY_IPS` to the IIP | |||
paulfitz
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issues described in #12.
When SSL is terminated externally, grist-omnibus receives requests via HTTP. In order for it to know that the end-user accessed it via HTTPS, the external reverse proxy should set X-Forwarded-* headers (only
X-Forwarded-Protomatters here), and traefik in grist-omnibus needs to know to trust it.The most secure way is to specify the IP address or range of the proxy, so that's the new environment variable being exposed.
In addition,
traefik-forward-authneeds its own flag to trust the X-Forwarded-* headers, as it is the piece that constructsredirect_uribased on whether it thinks the end-user is using HTTP or HTTPS.