actions: update upload-artifact to v4 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordigh
force-pushed
the
jordigh/actions
branch
2 times, most recently
from
57555fc to
b54a7af
Compare
That's the same version we use in Grist Core now.
Time to get with the times.
jordigh
force-pushed
the
jordigh/actions
branch
from
f7b32da to
c348fd3
Compare
v3 is scheduled for removal at the end of this month.
jordigh
force-pushed
the
jordigh/actions
branch
3 times, most recently
from
cb8b721 to
1630b89
Compare
Have you checked that Grist runs correctly against the resulting artifacts? |
This makes it match the current version we use in our grist-core Dockerfile.
jordigh
force-pushed
the
jordigh/actions
branch
from
2a56141 to
d46d163
Compare
Yes, it works, once I actually built for amd64 bookworm arch that matches the core Docker image. I'm not exactly sure what these artifacts are for. The v3 version of this just silently overwrote all the artifacts in-place until only the last OS+architecture configuration to finish building was left standing. This kind of means the artifacts never worked, from what I can tell. Anyway, I got it to work this time, provided someone hooks up a Mac for the M1 build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3 is scheduled for removal at the end of this month.
Tested that these changes produce a clean run.