Added #17687: Add User Responsible for a maintenances. #17907
Conversation
greatman
force-pushed
the
feat/17687
branch
from
44a66f5 to
443e030
Compare
There was a problem hiding this comment.
This looks pretty good, thanks! I have a few requests here, but also I think I'd probably want to reverse the logic in the name, Responsible User versus User Responsible.
It could also get a little confusing, since this "responsible" could be interpreted as the person responsible for causing a maintenance event, versus the person responsible for ensuring the maintenance is handled.
I was actually already working on this issue (I have a branch that wasn't pushed up yet.) It's often better to ask first, just so we're not duplicating efforts :)
| 'completion_date' => 'date_format:Y-m-d|nullable|after_or_equal:start_date', | ||
| 'notes' => 'string|nullable', | ||
| 'cost' => 'numeric|nullable|gte:0|max:99999999999999999.99', | ||
| 'user_responsible_id' => 'nullable|integer' |
There was a problem hiding this comment.
We probably want a check here to make sure the user's ID exists in the user table.
| 'asset.supplier' => ['name'], | ||
| 'asset.assetstatus' => ['name'], | ||
| 'supplier' => ['name'], | ||
| 'user_responsible' => ['first_name', 'last_name'], |
There was a problem hiding this comment.
I think you want to refer to the relationship here, no? userResponsible down below.
| * | ||
| * @return \Illuminate\Database\Eloquent\Relations\Relation | ||
| */ | ||
| public function maintenanceCausedBy() |
There was a problem hiding this comment.
Can we rename this to maintenanceCausedByUser or causedByUser for clarity?
2 participants
Add #17687.
This adds a User responsible field to maintenances. That way, we can track who cost a lot to a company.
The information is available both in the Users & the maintenance page.