Fixed #15664 - Adds Accessories, Components, Consumables, and Licenses to Unaccepted Assets report #17913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godmartinz
changed the title
Godmartinz
changed the title
marcusmoore
requested changes
Sep 23, 2025
|
@marcusmoore thanks for going over this, all change requests have been added. Thank you sir 🙂 |
|
Just noticed the resend button is bugged. putting back into WIP for a moment |
|
Resend button works 🥳 |
…ccepted_asset_report
|
oof forgot about the command. |
update the snipeit reminder command
|
command updated 👍 |
snipe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Unaccepted Assets report to include accessories, components, consumables and licenses. It handles the different model structures through a view-model/ DTO.
This also changes the CSV Download to mirror the changes done in the GUI.
The one thing that is not here is sorting chronologically, you can search just fine though.
NOTE: this cherry picks the work done in #17925 as it is necessary for testing this work.
Table:
CSV:
The
snipeit:acceptance-reminderhas been updated as wellNotice there are two users with a total of five pending checkouts
Console:
Email:
Fixes #15664