msrv: a command input - check or test - #28
Open
gronke wants to merge 1 commit into
Open
Conversation
cargo test on the MSRV extends the floor to dev-dependencies and the test suite; the source stays read-only, so tests must not write into the checkout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
commandinput to the msrv action:check(default, unchanged) ortest, which runscargo testinside the MSRV image so dev-dependencies and the test suite are held to the declared floor too - a dev-dep raising its MSRV currently drifts past a check-only gate unnoticed.msrv.shvalidates the value (check|test) and runscargo $commandwith the same pkg/offline/--locked/features shaping; the read-only source mount is unchanged, so tests that write into the checkout fail by design (documented on the input).command: "test"once a release carries this (its dev-dep MSRVs, jsonschema 1.83, proptest 1.66).