Fix: test-options with tag counting wrong file entries #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
Jul 21, 2025
| /(_spec\.rb|\.feature)$/ | ||
| end | ||
|
|
||
| def find_tests(tests, options = {}) |
There was a problem hiding this comment.
can we reuse super somehow so we don't have to copy-paste that much ?
grosser
reviewed
Jul 21, 2025
|
|
||
| module ParallelTests | ||
| module RSpec | ||
| class RuntimeJsonFormatter |
grosser
reviewed
Jul 21, 2025
grosser
reviewed
Jul 21, 2025
| ParallelTests::RSpec::Runner.send(:find_tests, *args) | ||
| end | ||
|
|
||
| it "finds turnip feature files" do |
There was a problem hiding this comment.
what happened to the old tests ?
grosser
reviewed
Jul 21, 2025
| it "finds turnip feature files" do | ||
| with_files(['a/test.feature']) do |root| | ||
| expect(call(["#{root}/"])).to eq(["#{root}/a/test.feature"]) | ||
| context 'without --tag' do |
There was a problem hiding this comment.
these tests don't really test the outcome, but how things pass around under the hood, so kind of easy to break and hard to understand
... we we instead test an outcome like that it runs the tests that have the given tag and not the others ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #598
Checklist
master(if not - rebase it).code introduces user-observable changes.