-
Notifications
You must be signed in to change notification settings - Fork 298
test: verify minProtocol and maxProtocol in connect request #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anschmieg
wants to merge
11
commits into
grp06:main
Choose a base branch
from
anschmieg:fix/connect-protocol-params
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a49e0fe
test: verify minProtocol and maxProtocol in connect request
anschmieg 577db57
test: verify no nested protocol object in connect params
anschmieg 285c81e
fix: disable access token requirement
anschmieg 3cd1535
chore: add build timestamp
anschmieg 02f49a2
fix: disable access token in assertPublicHostAllowed
anschmieg f3771ab
chore: cache buster
anschmieg 9262163
chore: update cache buster for rebuild
anschmieg af97ea4
chore: add cache buster comment to force rebuild
anschmieg 497c0cd
fix: add workaround for Next.js 16 Turbopack prerender bug
anschmieg e3b7c62
chore: add build timestamp to force rebuild
anschmieg 47d4c4c
fix: disable access token check
anschmieg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test asserts
params.minProtocol/params.maxProtocolare3, but it doesn’t verify the PR’s stated requirement that these fields are not nested under aparams.protocolobject (or that noprotocolobject is present at all). Consider also asserting thatparsed.params.protocolisundefined(or that the only protocol-related keys areminProtocol/maxProtocol) to fully cover the regression described in #101 and the PR description.