grpc: Add endpoints in resolverWrapper.NewAddress #8149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8149 +/- ##
=======================================
Coverage 82.30% 82.31%
=======================================
Files 389 392 +3
Lines 39125 39140 +15
=======================================
+ Hits 32203 32218 +15
- Misses 5594 5595 +1
+ Partials 1328 1327 -1
🚀 New features to boost your workflow:
|
arjan-bal
changed the title
dfawley
approved these changes
Mar 6, 2025
scripts/vet.sh
Outdated
Comment on lines
200
to
201
| XXXXX PleaseIgnoreUnused | ||
| NewAddress is deprecated:' |
There was a problem hiding this comment.
Suggested change
| XXXXX PleaseIgnoreUnused | |
| NewAddress is deprecated:' | |
| NewAddress is deprecated: | |
| XXXXX PleaseIgnoreUnused' |
That last line is there to avoid need to move the ' around. Also, let's try to keep this list sorted, so actually, please move this to right before NewSubConn is deprecated:.
arjan-bal
changed the title
arjan-bal
changed the title
arjan-bal
changed the title
arjan-bal
added a commit
to arjan-bal/grpc-go
that referenced
this pull request
Mar 6, 2025
arjan-bal
added a commit
that referenced
this pull request
Mar 6, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8146
The resolver wrapper has code in the UpdateState method to convert Addresses to Endpoints, but this handling was missing in the NewAddresses API. This PR adds it.
RELEASE NOTES: