11922 :: UdsChannelBuilder does not work with WiFi Proxy on Android. #12324
Conversation
| @@ -81,7 +82,10 @@ public static ManagedChannelBuilder<?> forPath(String path, Namespace namespace) | |||
| OKHTTP_CHANNEL_BUILDER_CLASS | |||
| .getMethod("socketFactory", SocketFactory.class) | |||
| .invoke(builder, new UdsSocketFactory(path, namespace)); | |||
| return builder; | |||
| if (builder == null) { | |||
There was a problem hiding this comment.
Remove this check for builder == null. There is no need for this check.
There was a problem hiding this comment.
Thanks @kannanjgithub for the review. I've added a null check to resolve the following warnings and satisfy the code quality check:
Warning:(85, 22) Method invocation 'proxyDetector' may produce 'NullPointerException'
The warnings will be resolved with 'assert builder != null' or a 'null check'. Could you please confirm if it's okay for me to ignore these warnings and remove the null check?
There was a problem hiding this comment.
You can suppress the warnings. NPE will happen for reflected methods when the requested method name or class name is not available but that cannot happen here since we know they are definitely available.
There was a problem hiding this comment.
Thanks for the suggestions @kannanjgithub , I have addressed the review comments and please review it once You get some bandwidth.
Fixes : #11922