-
Notifications
You must be signed in to change notification settings - Fork 109
Add List method to gRPC Health service #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoshuck
commented
Feb 12, 2024
Proposal: grpc/proposal#468 |
Falco20019
reviewed
Dec 18, 2024
purnesh42H
reviewed
Mar 10, 2025
dfawley
reviewed
Mar 20, 2025
Signed-off-by: Marcos Huck <[email protected]>
dfawley
reviewed
Mar 24, 2025
Signed-off-by: Marcos Huck <[email protected]>
dfawley
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for the changes!
markdroth
approved these changes
Mar 25, 2025
@ejona86, please take a look, and then we can get this merged. |
ejona86
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Clients cannot get a list of the services a certain server is watching to and their respective status.
In the context of Kubernetes, we have
livez
andreadyz
endpoints, by listing all the services a server is checking, we could return a response like the/readyz?verbose
Kubernetes API returns:Use case
This is not only useful for having status reports like Kubernetes
readyz
endpoints; it also allows services to simplify the set up when creating microservices that publish their status to status page systems such as:Change
This PR introduces a new
List
endpoint to theHealth
service in order to list all the services that a certain server is watching to.Alternative solution
We could extract the
List
endpoint into a new service to avoid breaking thev1
API. A newHealthLister
(or any other name) must be created.Proposal
grpc/proposal#468