-
Notifications
You must be signed in to change notification settings - Fork 2
Release/v4.8.0 #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v4.8.0 #145
Conversation
π[Release v4.4.1] Merge into Develop
This reverts commit 4e252ac. # Conflicts: # app/src/main/java/com/brainwallet/tools/manager/APIManager.kt
Add version and code to welcome screen
This reverts commit 4e252ac. # Conflicts: # app/src/main/java/com/brainwallet/tools/manager/APIManager.kt
β¦et-co/android into hotfix/api-manager-fix
Hotfix/api manager fix
fix: race condition when clear shared prefs values after wipeAll
Feat/new peer discovery
from the new peer discovery (v4.2.0)
* chore: update core submodule * chore: resolve conflict * Update build.gradle.kts version and code bump * chore: for now at BRPeerManager.wrapConnectV2 only using connect, since the core using hardcoded peers * fix: fix write down confirm screen (#63) * fix: fix write down confirm screen * fix: fix allow seed word item not unique * chore: cherry picked and adjust from - f2fa8e1 - 98644c4 - 9396927 - 7ad4b98 - 8e57d2a * fix: fix crash can't parse response inside LtcRepository.fetchRates * fix: fix crash (failed parse) when SelectedPeersRepository.fetchSelectedPeers got unsuccessful response * code bump * fix: ConcurrentModificationException at BRPeerManager.txStatusUpdate * feat: implement new API * code bump --------- Co-authored-by: Kerry Washington <[email protected]>
β¦se the previous response is still open (#73)
The Indonesian language code "in" is normalized to "id" in `MessagingTopicDataSource` to align with the ISO 639-1 standard used by the backend. This ensures consistency in topic generation for Indonesian language users. Tests have been added to verify this normalization for both "in" and "in_ID" inputs.
* feat: integrate build logic submodule Integrates the `gruntsoftware-build-logic` Git submodule into the project. This change includes: - Adding the submodule to `.gitmodules`. - Including the build logic in `settings.gradle.kts`. - Applying build logic plugins (`test` and `detekt`) in `app/build.gradle.kts`. * chore(detekt): apply baseline rules * chore: Remove ktlint from project This commit removes the ktlint configuration and associated tasks from the `app/build.gradle.kts` file. It also removes the `pinterest-ktlint` dependency from the `gradle/libs.versions.toml` file.
* Fixed the Git Submodule references
* updated gitmodules config
* create private gp submodule
* Update settings.gradle.kts
* chore: Migrate build logic to version catalog and update submodules
This commit migrates the project's build logic to use a centralized version catalog (`grunt`) and updates submodule references.
Specific changes include:
* **Submodule Updates:**
* Updated `gruntsoftware-build-logic` submodule pointer.
* Updated `modules/private-general-purpose` submodule pointer.
* **Build Configuration (`settings.gradle.kts`):**
* Removed the conditional loading of the `games` version catalog.
* Added a `grunt` version catalog loaded from `gruntsoftware-build-logic/gradle/libs.versions.toml`.
* Changed the included module from `:modules:private-general-purpose:content` to `:modules:private-general-purpose:games`.
* Removed conditional inclusion logic for `:modules:private-general-purpose:content`.
* **Root `build.gradle.kts`:**
* Updated plugin aliases from `libs.plugins.android.*` to `grunt.plugins.android.*`.
* **App `build.gradle.kts`:**
* Updated plugin alias for `com.android.application` from `libs` to `grunt`.
* Updated the `games` module dependency to `implementation(project(":modules:private-general-purpose:games"))` and removed the conditional logic for `findProject(":modules:games:content")`.
* Updated various dependencies to use the `grunt` version catalog (e.g., `grunt.androidx.core.ktx`, `grunt.androidx.compose.bom`, `grunt.bundles.androidx.compose`, `grunt.material`).
* **Version Catalog (`gradle/libs.versions.toml`):**
* Removed versions for `agp` and `androidx-core-ktx`.
* Removed versions for `androidx-compose-bom`, `androidx-activity-compose`, and `androidx-fragment-compose`.
* Removed `androidx-core` library alias.
* Removed various `androidx-compose` library aliases and the `androidx-compose` bundle.
* Removed `android-application` and `android-library` plugin aliases.
* ci: Configure GitHub token for submodules in CircleCI
This commit updates the CircleCI configuration to include a step that configures a GitHub token. This token will be used for authenticating access to submodules during the build process.
* refactor: Update module paths for 'games'
This commit refactors the project structure by moving the 'games' module.
- The 'games' module path in `settings.gradle.kts` is changed from `:modules:private-general-purpose:games` to `:games` and its `projectDir` is set to `modules/private-general-purpose/games`.
- The dependency path in `app/build.gradle.kts` for the 'games' module is updated from `project(":modules:private-general-purpose:games")` to `project(":games")`.
The submodule references for `gruntsoftware-build-logic` and `modules/private-general-purpose` were also updated.
---------
Co-authored-by: Joseph Sanjaya <[email protected]>
This commit migrates the project's build logic to use a centralized version catalog (`grunt`) and updates submodule references.
Specific changes include:
* **Submodule Updates:**
* Updated `gruntsoftware-build-logic` submodule pointer.
* Updated `modules/private-general-purpose` submodule pointer.
* **Build Configuration (`settings.gradle.kts`):**
* Removed the conditional loading of the `games` version catalog.
* Added a `grunt` version catalog loaded from `gruntsoftware-build-logic/gradle/libs.versions.toml`.
* Changed the included module from `:modules:private-general-purpose:content` to `:modules:private-general-purpose:games`.
* Removed conditional inclusion logic for `:modules:private-general-purpose:content`.
* **Root `build.gradle.kts`:**
* Updated plugin aliases from `libs.plugins.android.*` to `grunt.plugins.android.*`.
* **App `build.gradle.kts`:**
* Updated plugin alias for `com.android.application` from `libs` to `grunt`.
* Updated the `games` module dependency to `implementation(project(":modules:private-general-purpose:games"))` and removed the conditional logic for `findProject(":modules:games:content")`.
* Updated various dependencies to use the `grunt` version catalog (e.g., `grunt.androidx.core.ktx`, `grunt.androidx.compose.bom`, `grunt.bundles.androidx.compose`, `grunt.material`).
* **Version Catalog (`gradle/libs.versions.toml`):**
* Removed versions for `agp` and `androidx-core-ktx`.
* Removed versions for `androidx-compose-bom`, `androidx-activity-compose`, and `androidx-fragment-compose`.
* Removed `androidx-core` library alias.
* Removed various `androidx-compose` library aliases and the `androidx-compose` bundle.
* Removed `android-application` and `android-library` plugin aliases.
This commit adds the `kotlinx-collections-immutable` library, version 0.4.0, to the project's dependencies.
Updates the import paths for the core presentation module from `ltd.grunt.brainwallet.core.presentation` to `com.grunt.brainwallet.core.presentation`. This refactoring touches multiple UI components and initializers across the `app` module to align with the new package structure. Additionally, this commit corrects a typo in `SeedWordItem.kt`, changing the error color variable from `chilli` to `chili` to match the theme definition. Finally, the submodule pointer for `private-general-purpose` is updated.
feat(export-transactions): implement in-app purchase
|
@JosephSanjaya :
|
|
Syre let me take a look |
|
Done @kcw-grunt, i see there's still package submodules that supposed to be deleted |
|
This version is approved by the Play Store. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! @kcw-grunt
Thanks for the look @josikie |
|
Play Store approved |
|
My pleasure @kcw-grunt |
π± Description
Platform
π― Type of Change
π Changes
π Related Issues
π§ͺ Tests Status
πΈ Screenshots/Videos
π― Reviewers
@kcw-grunt, @josikie