-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix inconsistencies in CLI documentation #4893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix inconsistencies in CLI documentation #4893
Conversation
Updated command examples for clarity and accuracy regarding the use of the 'run' command in Terragrunt CLI, which was presenting itself with a repeated command definition. Also changed upper reference regarding the `graph` flag to match the definition on the bottom of the page.
📝 WalkthroughWalkthroughUpdated the CLI-redesign migration docs: corrected command examples and prose to use the intended run vs run-all forms, fixed flag formatting (explicit Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs-starlight/src/content/docs/07-migrate/03-cli-redesign.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs-starlight/**/*.md*
⚙️ CodeRabbit configuration file
Review the documentation for clarity, grammar, and spelling. Make sure that the documentation is easy to understand and follow. There is currently a migration underway from the Jekyll based documentation in
docsto the Starlight + Astro based documentation indocs-starlight. Make sure that thedocs-starlightdocumentation is accurate and up-to-date with thedocsdocumentation, and that any difference between them results in an improvement in thedocs-starlightdocumentation.
Files:
docs-starlight/src/content/docs/07-migrate/03-cli-redesign.md
Clarify usage of deprecated 'graph' command and flag separation.
|
|
||
| ```bash | ||
| terragrunt run graph | ||
| terragrunt run --graph plan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, this is wrong. The point of the command above is that the OpenTofu/Terraform command can't be run without using the run command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much knowledge on this flag. CodeRabbit, when i changed it to terragrunt run --graph only, suggested the changes above.
I followed this run --graph command usage description, in the documentation. Also, here, in the new CLI redesign section, it says to use terragrunt run graph. Please indicate the right usage to correctly apply the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's confusing, but there are two different graph commands, which drove some of the adjustments in the CLI Redesign project.
- There's the OpenTofu/Terraform graph command
- Terragrunt also has used to have a command named
graph, which was removed, and the behavior ofrunwas updated to include the--graphflag, which replaced it.
For some OpenTofu/Terraform commands, if there's no ambiguity, we directly forward the command from Terragrunt to OpenTofu/Terraform.
e.g.
terragrunt planUnder the hood, calls either tofu plan or terraform plan, depending on the user's configurations.
This is just a shortcut, though, and it's the same as running the following:
terragrunt run planFor other commands like graph, we don't want users who were using the old Terragrunt graph command to get confused when they see OpenTofu running the graph command, so we instead require that they explicitly use the run form if they want Terragrunt to run the OpenTofu command.
terragrunt run graphYou can see in the line above where you're proposing changes that we're explaining this:
Similarly, commands like
graphwon't be supported as a shortcut, asgraphis a now deprecated command in the Terragrunt CLI. Supporting it as a shortcut would be misleading, so you can use theruncommand to run it explicitly:
If you think we can be clearer about the explanation, please consider updating that line to make it clearer.
|
Hey @pedromtsilva , Do you have a sec to rebase this PR and address the feedback? |
Updated command examples for clarity and accuracy regarding the use of the 'run' command in Terragrunt CLI, which was presenting itself with a repeated command definition.
Also changed upper reference regarding the
graphflag to match the definition on the bottom of the page.Description
Fixes #4892.
TODOs
Read the Gruntwork contribution guidelines.
Summary by CodeRabbit