Skip to content

Conversation

@yhakbar
Copy link
Collaborator

@yhakbar yhakbar commented Oct 23, 2025

Description

Moves the logic for dag graph to list --format=dot.

Relates to #4745

TODOs

Read the Gruntwork contribution guidelines.

  • I authored this code entirely myself
  • I am submitting code based on open source software (e.g. MIT, MPL-2.0, Apache)]
  • I am adding or upgrading a dependency or adapted code and confirm it has a compatible open source license
  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added --format=dot to list command to generate DAG graphs in DOT format.
Removed dag graph command.

Migration Guide

@vercel
Copy link

vercel bot commented Oct 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
terragrunt-docs Ready Ready Preview Comment Nov 4, 2025 11:36pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/moving-dag-graph-to-list

Comment @coderabbitai help to get the list of available commands and usage tips.

@yhakbar yhakbar force-pushed the docs/documenting-support-for-filter-in-hcl-commands branch 4 times, most recently from 9a4bd40 to cb39153 Compare October 24, 2025 19:51
Base automatically changed from docs/documenting-support-for-filter-in-hcl-commands to main October 27, 2025 14:44
@yhakbar yhakbar force-pushed the feat/moving-dag-graph-to-list branch from 042ecf7 to 067f83b Compare October 27, 2025 15:11
@yhakbar yhakbar force-pushed the feat/moving-dag-graph-to-list branch from 067f83b to 68fd74a Compare October 27, 2025 15:14
@yhakbar yhakbar force-pushed the feat/moving-dag-graph-to-list branch from 68fd74a to 73d0999 Compare October 27, 2025 21:41
@yhakbar yhakbar changed the base branch from main to chore/disable-experimental-ci-ignore October 27, 2025 21:43
@yhakbar yhakbar force-pushed the feat/moving-dag-graph-to-list branch from 73d0999 to 4fff8ac Compare October 27, 2025 21:44
@yhakbar yhakbar force-pushed the chore/disable-experimental-ci-ignore branch from c70563d to 2414861 Compare October 28, 2025 16:45
@yhakbar yhakbar force-pushed the feat/moving-dag-graph-to-list branch from 4fff8ac to ce7fa82 Compare October 28, 2025 16:57
@yhakbar yhakbar force-pushed the chore/disable-experimental-ci-ignore branch from 2414861 to c9dff4c Compare October 28, 2025 19:03
@yhakbar yhakbar force-pushed the feat/moving-dag-graph-to-list branch from ce7fa82 to 11e5875 Compare October 28, 2025 19:14
@yhakbar yhakbar force-pushed the chore/disable-experimental-ci-ignore branch 2 times, most recently from ed880b5 to a62cb8a Compare October 28, 2025 19:59
@yhakbar yhakbar force-pushed the feat/moving-dag-graph-to-list branch from 11e5875 to e4ca449 Compare October 28, 2025 20:29
@yhakbar yhakbar force-pushed the chore/disable-experimental-ci-ignore branch 3 times, most recently from c574388 to 4de37b3 Compare October 30, 2025 16:01
@yhakbar yhakbar force-pushed the feat/moving-dag-graph-to-list branch from e4ca449 to d2e56e6 Compare October 30, 2025 16:42
@yhakbar yhakbar marked this pull request as ready for review October 30, 2025 20:24
@yhakbar yhakbar requested a review from denis256 as a code owner October 30, 2025 20:24
@yhakbar yhakbar force-pushed the chore/disable-experimental-ci-ignore branch from 007e256 to c5dba38 Compare November 4, 2025 22:22
@yhakbar yhakbar force-pushed the feat/moving-dag-graph-to-list branch from d2e56e6 to 45dab5e Compare November 4, 2025 22:24
@yhakbar yhakbar force-pushed the chore/disable-experimental-ci-ignore branch 2 times, most recently from b684454 to 7c30c1b Compare November 4, 2025 23:34
fix: Sort results for consistency in tests
denis256
denis256 previously approved these changes Nov 5, 2025
assert.Equal(t, aPath, units[1].Dependencies[0].Path)
}

func TestUnits_WriteDot(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we don't have a replacement for this test

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do here, right?
https://github.com/gruntwork-io/terragrunt/pull/5013/files#diff-55966a3093157e3fd03d7513ad5b72286a69160ff999f09495d6af629097252bR591

The Unit struct no longer manages Dot format writing, the list command does.

Base automatically changed from chore/disable-experimental-ci-ignore to main November 5, 2025 13:34
@yhakbar yhakbar dismissed denis256’s stale review November 5, 2025 13:34

The base branch was changed.

@yhakbar yhakbar merged commit 29825b8 into main Nov 5, 2025
122 of 124 checks passed
@yhakbar yhakbar deleted the feat/moving-dag-graph-to-list branch November 5, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants