-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: Refactor find & list so that they use a single write instead of intermediate writes
#5027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughTwo CLI command files are refactored to buffer output before writing. The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Comment |
2649355 to
5d7bce5
Compare
73d0999 to
4fff8ac
Compare
5d7bce5 to
d0fe23d
Compare
e4ca449 to
d2e56e6
Compare
d0fe23d to
a7b88bd
Compare
d2e56e6 to
45dab5e
Compare
a7b88bd to
e7e9374
Compare
45dab5e to
e919a0a
Compare
e7e9374 to
354ce39
Compare
…ad of intermediate writes
354ce39 to
5c9415c
Compare
Description
Refactors
find&listso that they build up the string they're going to write before writing.Ensures write operation is atomic, and prevents unnecessary syscalls.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide
Summary by CodeRabbit
Release Notes