Skip to content

Conversation

@yhakbar
Copy link
Collaborator

@yhakbar yhakbar commented Oct 28, 2025

Description

Starts integrating filters into the logic for discovery so that we can prevent discovery of components when certain filters are set.

TODOs

Read the Gruntwork contribution guidelines.

  • I authored this code entirely myself
  • I am submitting code based on open source software (e.g. MIT, MPL-2.0, Apache)]
  • I am adding or upgrading a dependency or adapted code and confirm it has a compatible open source license
  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@vercel
Copy link

vercel bot commented Oct 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
terragrunt-docs Ready Ready Preview Comment Nov 4, 2025 11:41pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/integrating-filters-into-discovery

Comment @coderabbitai help to get the list of available commands and usage tips.

@yhakbar yhakbar force-pushed the chore/disable-experimental-ci-ignore branch 3 times, most recently from c574388 to 4de37b3 Compare October 30, 2025 16:01
@yhakbar yhakbar force-pushed the feat/integrating-filters-into-discovery branch from d4e5a07 to 474e9ed Compare October 30, 2025 16:58
@yhakbar yhakbar force-pushed the chore/disable-experimental-ci-ignore branch 3 times, most recently from b684454 to 7c30c1b Compare November 4, 2025 23:34
chore: Renaming `RequiresHCLParsing` to `RequiresDiscovery` as that captures the essence of the check better

chore: Testing exclude by default with filters
@yhakbar yhakbar force-pushed the feat/integrating-filters-into-discovery branch from 845b4f8 to 652c6dc Compare November 4, 2025 23:40
Base automatically changed from chore/disable-experimental-ci-ignore to main November 5, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants