Accessability Pass - PreCache Images #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es, and went ahead and moved old, disused precacheImage code in there as well to see if it works.
…rTeam/flutter-wonderous-app into accessability-pass-cache
|
Poked a quick fix into the precache images branch. Simply upped the aforementioned maxWidth to 10000. Tested it vigorously to ensure it didn't do anything bad as a side-effect. |
esDotDev
approved these changes
Oct 30, 2025
Merge issues with minor-updates branch, which we originally based precache on but never pushed. Reverting those changes so that we can push those updates in their own PR.
Merge issues with minor-updates branch, which we originally based precache on but never pushed. Reverting those changes so that we can push those updates in their own PR.
Last file that needed this treatment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added precacheImage calls to icons, moved them to didChangeDependencies, and went ahead and moved old, disused precacheImage code in there as well to see if it works.
Did some modifications to the precache code, making it run asyncronously (somehow helps) and cache several more images. Also cleaned the code up a fair bit, universalizing the precache code to work for both icons and illustrations and throw errors if things go wrong. The big change was the correction to the URLs; initially it didn't work because it tried to load the files from the wrong source.
Tested mainly on Web, as the precache only runs if kIsWeb = true.