Skip to content

Commit 7e0880d

Browse files
committedJun 11, 2013
Complete rewritte based on Celluloid
Work in progress (doesn't work yet)
1 parent d77b7a8 commit 7e0880d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+3791
-3862
lines changed
 

‎CHANGELOG.md

+72-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,61 @@
1+
## 1.2.0 - Jun 11, 2013
2+
3+
### Improvement
4+
5+
- [#124][] New `force_adapter` option, skip the `.listen_test` adapter test. ([@nicobrevin][])
6+
7+
## 1.1.6 - Jun 4, 2013
8+
9+
### Change
10+
11+
- [#120][] Warn when using relative_paths option when listening to multiple diretories. (reported by [@chriseppstein][], added by [@thibaudgg][])
12+
13+
## 1.1.5 - Jun 3, 2013
14+
15+
### Bug fix
16+
17+
- [#122][] Fix stop called very soon after starting. (reported by [@chriseppstein][], fixed by [@thibaudgg][])
18+
19+
## 1.1.4 - May 28, 2013
20+
21+
### Bug fix
22+
23+
- [#118][] Prevent polling just because the adapter gem was already required. ([@nilbus][])
24+
25+
## 1.1.3 - May 21, 2013
26+
27+
### Bug fix
28+
29+
- [#117][] Fix jruby error on Pathname#relative_path_from. ([@luikore][])
30+
31+
## 1.1.2 - May 14, 2013
32+
33+
### Bug fix
34+
35+
- [#115][] Fix for directory containing non-ascii chars. ([@luikore][])
36+
37+
## 1.1.1 - May 14, 2013
38+
39+
### Bug fix
40+
41+
- [#113][] Kill poller_thread before waiting for it to die. ([@antifuchs][])
42+
43+
## 1.1.0 - May 11, 2013
44+
45+
### Bug fix
46+
47+
- [#112][] Expand path for the given directories. (reported by [@nex3][], fixed by [@thibaudgg][])
48+
49+
### Change
50+
51+
- [#110][] Remove MultiListener deprecation warning message. (reported by [@nex3][], fixed by [@thibaudgg][])
52+
53+
## 1.0.3 - April 29, 2013
54+
55+
### Bug fix
56+
57+
- Rescue Errno::EBADF on sha1_checksum generation. ([@thibaudgg][])
58+
159
## 1.0.2 - April 22, 2013
260

361
### Bug fix
@@ -250,15 +308,26 @@
250308
[#98]: https://github.com/guard/listen/issues/98
251309
[#103]: https://github.com/guard/listen/issues/103
252310
[#104]: https://github.com/guard/listen/issues/104
311+
[#110]: https://github.com/guard/listen/issues/110
312+
[#112]: https://github.com/guard/listen/issues/112
313+
[#113]: https://github.com/guard/listen/issues/113
314+
[#115]: https://github.com/guard/listen/issues/115
315+
[#117]: https://github.com/guard/listen/issues/117
316+
[#118]: https://github.com/guard/listen/issues/118
317+
[#120]: https://github.com/guard/listen/issues/120
318+
[#122]: https://github.com/guard/listen/issues/122
319+
[#124]: https://github.com/guard/listen/issues/124
253320
[@Maher4Ever]: https://github.com/Maher4Ever
254321
[@ahoward]: https://github.com/ahoward
255322
[@akerbos]: https://github.com/akerbos
256323
[@antifuchs]: https://github.com/antifuchs
324+
[@chriseppstein]: https://github.com/chriseppstein
257325
[@cobychapple]: https://github.com/cobychapple
258326
[@daemonza]: https://github.com/daemonza
259327
[@dkubb]: https://github.com/dkubb
260328
[@ebroder]: https://github.com/ebroder
261329
[@fny]: https://github.com/fny
330+
[@luikore]: https://github.com/luikore
262331
[@markiz]: https://github.com/markiz
263332
[@martikaljuve]: https://github.com/martikaljuve
264333
[@mat813]: https://github.com/mat813
@@ -267,6 +336,8 @@
267336
[@napcs]: https://github.com/napcs
268337
[@netzpirat]: https://github.com/netzpirat
269338
[@nex3]: https://github.com/nex3
339+
[@nicobrevin]: https://github.com/nicobrevin
340+
[@nilbus]: https://github.com/nilbus
270341
[@nysalor]: https://github.com/nysalor
271342
[@piotr-sokolowski]: https://github.com/piotr-sokolowski
272343
[@rymai]: https://github.com/rymai
@@ -276,4 +347,4 @@
276347
[@textgoeshere]: https://github.com/textgoeshere
277348
[@thibaudgg]: https://github.com/thibaudgg
278349
[@vongruenigen]: https://github.com/vongruenigen
279-
[@zanker]: https://github.com/zanker
350+
[@zanker]: https://github.com/zanker

‎Gemfile

+4-4
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ require 'rbconfig'
88
gem 'wdm', '>= 0.1.0' if RbConfig::CONFIG['target_os'] =~ /mswin|mingw/i
99

1010
group :development do
11-
gem 'guard-rspec'
12-
gem 'yard'
13-
gem 'redcarpet'
14-
gem 'pimpmychangelog'
11+
gem 'guard-rspec', require: false
12+
gem 'yard', require: false
13+
gem 'redcarpet', require: false
14+
gem 'pimpmychangelog', require: false
1515
end
1616

1717
group :test do

11 commit comments

Comments
 (11)

gregoriokusowski commented on Oct 6, 2013

@gregoriokusowski

I know this commit was a WIP one, but the Listener blocking start! method was removed here, and isn't present on 2.0.0.
Will v 2.0.0 have this method?
Thanks!

thibaudgg commented on Oct 7, 2013

@thibaudgg
MemberAuthor

Yeah for me start! was confusing, so I removed it and I have no plan to re-add it. The new start method is non-blocking and if you want the process to block just call sleep after start, seems way simpler for me. Sounds good to you too?

gregoriokusowski commented on Oct 9, 2013

@gregoriokusowski

It was a bit confusing for me too. I asked this when I was investigating alexch/rerun#44 alexch/rerun#45. It's like I'm #lateonparty, heh.
I'll try to figure out if rerun really need this.

Thanks!

alexch commented on Oct 16, 2013

@alexch
Contributor

I'm a little rusty on why I used start!, but it's probably because I need to monitor and kill the listener thread (from a master thread in the same process, so sleep doesn't cut it).

I suppose I'll have to dig into Celluloid and the new Listen now to figure out why Rerun's tests are failing, and see if it's possible to use Listen v2.

thibaudgg commented on Oct 16, 2013

@thibaudgg
MemberAuthor

What error do you see in rerun? Maybe it's the same issue that we have in spring: rails/spring#194

alexch commented on Oct 16, 2013

@alexch
Contributor

Actually it looks like the problem is that you removed the :filter option :-) ?!?

thibaudgg commented on Oct 16, 2013

@thibaudgg
MemberAuthor

Yep, use ignore option instead, it works the same way.

alexch commented on Oct 16, 2013

@alexch
Contributor

The same only opposite! (It should have been named "include", not "filter".) It's still useful to have both lists. Not to mention it's difficult to reliably programatically invert a regular expression.

thibaudgg commented on Oct 16, 2013

@thibaudgg
MemberAuthor

What about a new only (instead of include) option?

alexch commented on Oct 16, 2013

@alexch
Contributor

only is a fine synonym. 👍

thibaudgg commented on Oct 16, 2013

@thibaudgg
MemberAuthor

Ok I'll add that in the next days.

Please sign in to comment.