-
Notifications
You must be signed in to change notification settings - Fork 30
feat: Integrate Sign-In Gate Portal into Sticky Bottom Banner #14408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
juabara
merged 20 commits into
main
from
jm/feat-prevent-banner-and-sign-in-gate-together
Sep 18, 2025
+735
−515
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3180236
feat(wip): Integrate Sign-In Gate Portal into Sticky Bottom Banner
b8ce109
feat: Enhance StickyBottomBanner with AB testing support and improve …
b08b4dd
feat: remove sign-in gate selector from slot so only the sticky banne…
cf3461a
feat: remove Auxia AB testing code from SignInGateSelector, StickyBot…
ec85f7c
Merge branch 'main' of github.com:guardian/dotcom-rendering into jm/f…
4190028
fix: optimize message picking with Promise.allSettled
ebd4729
fix: set timeoutMillis to null to prevent hanging in problematic envi…
98eedb6
Merge branch 'main' into jm/feat-prevent-banner-and-sign-in-gate-toge…
juabara 15f93d2
fix: revert message picker changes
01da7d3
test: check if auxia api is being called in sign-in gate
975f8c7
feat: move auxia check from sign-in gate to sticky bottom banner
d034044
Merge branch 'main' of github.com:guardian/dotcom-rendering into jm/f…
4b76929
Merge branch 'main' into jm/feat-prevent-banner-and-sign-in-gate-toge…
juabara 70b36fb
fix: strong type sign-in gate candidate config
f0d994f
Merge branch 'main' into jm/feat-prevent-banner-and-sign-in-gate-toge…
juabara 0e6ca1d
fix: update sign-in gate portal tests
aa031c5
Merge branch 'main' into jm/feat-prevent-banner-and-sign-in-gate-toge…
juabara 2831516
fix: treatment type values in tests
0dcbaf5
fix: restore pnpm-lock.yaml
5a0077d
Merge branch 'main' into jm/feat-prevent-banner-and-sign-in-gate-toge…
juabara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.