Refactor image -> media
#14411
Merged
Refactor image -> media
#14411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlander
force-pushed
the
doml/refactor-image-wrapper
branch
from
c628131 to
89eed1e
Compare
domlander
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/refactor-image-wrapper
branch
from
89eed1e to
576d854
Compare
domlander
force-pushed
the
doml/refactor-image-wrapper
branch
from
576d854 to
d1d8ba8
Compare
github-actions
bot
removed
the
run_chromatic
abeddow91
reviewed
Aug 26, 2025
|
|
||
| const sizingStyles = ( | ||
| imageSize: ImageSizeType, | ||
| imageSize: MediaSizeType, |
There was a problem hiding this comment.
Assuming imageSize and imagePositionType have been left as is as avatar is (currently) always an image.
There was a problem hiding this comment.
Yep! I've tried to leave these alone when it can only be an image, with the goal of making it as easy as possible to understand for the reader. If we were to add another media type to Avatar, then we should update this prop.
abeddow91
approved these changes
Aug 26, 2025
|
Overdue on PROD (merged by @domlander 30 minutes and 8 seconds ago) What's gone wrong? |
|
Seen on PROD (merged by @domlander 5 hours, 37 minutes and 21 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Refactors mentions of
imagewhere over time this has come to meanmedia. We started displaying only images in fronts cards, but over time we have added slideshows, videos and more, somediais a better term for where this content is referenced.Why?
Less confusing to read the code.