Add story packages to galleries #14426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary reason for this change is to add support for story packages to the new gallery layout. At the moment every layout duplicates the same transformation on the frontend story package data, mapping over the trails with `decideTrail`. This change extracts the story package type definition and parsing into its own module, and calls the parsing code up front when the `Article` type is constructed (i.e. in one place rather than several). For now, we can only use this in galleries, as other layouts are still using the `ArticleDeprecated` type. Also adds a type annotation to the story package fixtures, so that we can use them in stories without type errors.
Consequence of resolving merge conflicts.
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
To make it fit the maximum snapshot size in chromatic Co-authored-by: Jamie B <[email protected]>
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @JamieB-gu 9 minutes and 1 second ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary reason for this change is to add support for story packages to the new gallery layout.
At the moment every layout duplicates the same transformation on the frontend story package data, mapping over the trails with
decideTrail. This change extracts the story package type definition and parsing into its own module, and calls the parsing code up front when theArticletype is constructed (i.e. in one place rather than several). For now, we can only use this in galleries, as other layouts are still using theArticleDeprecatedtype.Also adds a type annotation to the story package fixtures, so that we can use them in stories without type errors.
Resolves #14424.
Screenshots
Note: The grey box in the web screenshot is the "merchandising high" ad slot.