feat(imovo): imovo-rewards-project-startup #3389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| nameSuffix: 'consumer', | ||
| queueNameSuffix: `events`, | ||
| lambdaOverrides: { | ||
| description: 'A lambda that handles stripe disputes SQS events', |
Member
There was a problem hiding this comment.
Suggested change
| description: 'A lambda that handles stripe disputes SQS events', | |
| description: 'A lambda that handles imovo voucher SQS requests', |
Member
graham228221
left a comment
graham228221
left a comment
There was a problem hiding this comment.
Generally looks fine! But as discussed I think we should name this stack something a bit more generic as they outputs won't always be "rewards".
My suggestion would be imovo-voucher-api (this opens up the possibility to migrate the existing digital-voucher-api scala stack into this typescript application in future).
There's a few copy/paste bits that mention the stripe-disputes work
Comment on lines
+37
to
+39
| `There are one or more failed dispute webhook events in the ${app} dead letter queue (DLQ). ` + | ||
| `Check the attributes of the failed message(s) for details of the error and ` + | ||
| 'ensure the Stripe webhook processing is working correctly.', |
Member
There was a problem hiding this comment.
A few copy and paste bits from the Stripe disputes work
Comment on lines
+154
to
+167
| function getStripeSecretPolicy(scope: SrStack) { | ||
| return new AllowGetSecretValuePolicy( | ||
| scope, | ||
| 'Allow Secrets Manager Stripe Webhooks policy', | ||
| 'Stripe/ConnectedApp/StripeDisputeWebhooks-*', | ||
| ); | ||
| } | ||
|
|
||
| function getSalesforceSecretPolicy(scope: SrStack) { | ||
| return new AllowGetSecretValuePolicy( | ||
| scope, | ||
| 'Allow Secrets Manager Salesforce policy', | ||
| 'Salesforce/ConnectedApp/StripeDisputeWebhooks-*', | ||
| ); |
Member
There was a problem hiding this comment.
We won't need these for this project (we will need the imovo credentials)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds the boilerplate infrastructure for a new imovo-rewards Lambda handler. This sets up everything needed so we can start building the Imovo rewards feature on top
of it.
Changes include:
How has this change been tested?
How can we measure success?
The Lambda is deployed and reachable in CODE. CloudWatch logs show successful invocations. This is scaffolding only -- real success metrics will come with the actual
feature implementation.
Have we considered potential risks?
Minimal risk. This is a new standalone stack with no impact on existing handlers. The Hello World handler has no external dependencies or access to sensitive data.