Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified DashboardController.php's actionAccomplishment function to prevent potential SQL injection attacks #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions controllers/DashboardController.php
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,15 @@ public function actionAccomplishment()
desc_category as n, MONTHNAME(date) as m, SUM(value) as v
FROM cashbook
INNER JOIN category
on category.id_category = cashbook.category_id
WHERE YEAR(date) = $thisyear AND cashbook.user_id = $user AND category_id = $category_id
ON category.id_category = cashbook.category_id
WHERE YEAR(date) = :thisyear AND cashbook.user_id = :user AND category_id = :category_id
GROUP BY desc_category, MONTHNAME(date)
ORDER BY desc_category ASC, MONTHNAME(date) asc;");
ORDER BY desc_category ASC, MONTHNAME(date) ASC;");

$command->bindValue(':thisyear', $thisyear);
$command->bindValue(':user', $user);
$command->bindValue(':category_id', $category_id);

$accomplishment = $command->queryAll();

$m = array();
Expand Down