Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Add JSON Schema Test Suite to CI #105

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

hudson-ai
Copy link
Collaborator

First attempt at getting the test suite running in CI. I don't really know how to effectively use github CI, so this is a bit of an experiment.

Note that this steals some code from a few existing scripts (namely sample_parser/src/json_schema_testsuite.rs).

TODOS:

  • commit some baseline version of the artifact for regression analysis
  • compare against baseline with helpful presentation of differences
  • build some process for bumping the baseline (probably just run a script and update committed baseline)

@hudson-ai
Copy link
Collaborator Author

@mmoskal ping for visibility

@mmoskal
Copy link
Collaborator

mmoskal commented Jan 7, 2025

You could just add it to the test-guidance.sh script (which we probably want to rename to build-and-test.sh or testall.sh or something). This way there is just one script to run to check if things still work locally. I guess running this suite takes a few seconds at most?

@hudson-ai
Copy link
Collaborator Author

You could just add it to the test-guidance.sh script (which we probably want to rename to build-and-test.sh or testall.sh or something). This way there is just one script to run to check if things still work locally. I guess running this suite takes a few seconds at most?

Sounds good, and yeah it's under a second :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants