Skip to content

Major refactoring WIP #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Major refactoring WIP #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6058b65
added helper method which can help to handle error and wrong status c…
Aug 28, 2025
ca1fa85
added field for new param
Aug 28, 2025
2a80ccd
replaced with better way to validate cli params
Aug 28, 2025
9c090aa
added classes with constants for different types of messages
Aug 28, 2025
68c8b92
new data class for test run and changes in existing: supporting subse…
Aug 28, 2025
3b78b6a
added nested suites support
Aug 28, 2025
2a2845f
added new boolean param to allow updating existing cases
Aug 28, 2025
eb64751
renaming
Aug 28, 2025
0212c2f
refactored and newly created packages
Aug 28, 2025
8127bca
added missing sections check for confirmation,
Aug 29, 2025
f3bd0a2
removed redundant method
Aug 29, 2025
348c0d6
fixed few bugs related to suite resolving, related refactoring as wall
Aug 30, 2025
f858f97
slightly refactored test run add/ update
Aug 30, 2025
6797841
replaced refference
Aug 30, 2025
526585d
moved instantiate_api_client to more appropriate place, changed some …
Sep 1, 2025
c27750b
Removed redundant methods, updated types hinting
Sep 2, 2025
fac7f3b
refactored test update run, encapsulated add_run for api data provider
Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions tests/test_data/results_provider_test_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,45 +83,45 @@
(
"delete_suite",
[
RevertMessages.run_deleted,
RevertMessages.test_cases_deleted,
RevertMessages.section_deleted,
RevertMessages.suite_not_deleted.format(
RevertMessages.RUN_DELETED,
RevertMessages.TEST_CASES_DELETED,
RevertMessages.SECTION_DELETED,
RevertMessages.SUITE_NOT_DELETED_FF_SUITE_ID_ERROR.format(
error="No permissions to delete suite."
),
],
),
(
"delete_sections",
[
RevertMessages.run_deleted,
RevertMessages.test_cases_deleted,
RevertMessages.section_not_deleted.format(
RevertMessages.RUN_DELETED,
RevertMessages.TEST_CASES_DELETED,
RevertMessages.SECTION_NOT_DELETED_FF_SECTION_ID_ERROR.format(
error="No permissions to delete sections."
),
RevertMessages.suite_deleted,
RevertMessages.SUITE_DELETED,
],
),
(
"delete_cases",
[
RevertMessages.run_deleted,
RevertMessages.test_cases_not_deleted.format(
RevertMessages.RUN_DELETED,
RevertMessages.TEST_CASES_NOT_DELETED_F_ERROR.format(
error="No permissions to delete cases."
),
RevertMessages.section_deleted,
RevertMessages.suite_deleted,
RevertMessages.SECTION_DELETED,
RevertMessages.SUITE_DELETED,
],
),
(
"delete_run",
[
RevertMessages.run_not_deleted.format(
RevertMessages.RUN_NOT_DELETED_FF_RUN_ID_ERROR.format(
error="No permissions to delete run."
),
RevertMessages.test_cases_deleted,
RevertMessages.section_deleted,
RevertMessages.suite_deleted,
RevertMessages.TEST_CASES_DELETED,
RevertMessages.SECTION_DELETED,
RevertMessages.SUITE_DELETED,
],
),
]
Expand All @@ -137,31 +137,31 @@
(
"delete_sections",
[
RevertMessages.run_deleted,
RevertMessages.test_cases_deleted,
RevertMessages.section_not_deleted.format(
RevertMessages.RUN_DELETED,
RevertMessages.TEST_CASES_DELETED,
RevertMessages.SECTION_NOT_DELETED_FF_SECTION_ID_ERROR.format(
error="No permissions to delete sections."
),
],
),
(
"delete_cases",
[
RevertMessages.run_deleted,
RevertMessages.test_cases_not_deleted.format(
RevertMessages.RUN_DELETED,
RevertMessages.TEST_CASES_NOT_DELETED_F_ERROR.format(
error="No permissions to delete cases."
),
RevertMessages.section_deleted,
RevertMessages.SECTION_DELETED,
],
),
(
"delete_run",
[
RevertMessages.run_not_deleted.format(
RevertMessages.RUN_NOT_DELETED_FF_RUN_ID_ERROR.format(
error="No permissions to delete run."
),
RevertMessages.test_cases_deleted,
RevertMessages.section_deleted,
RevertMessages.TEST_CASES_DELETED,
RevertMessages.SECTION_DELETED,
],
),
]
Expand Down
7 changes: 7 additions & 0 deletions trcli/api/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,13 @@ class APIClientResult:
response_text: Union[Dict, str, List]
error_message: str

def error_or_bad_code(self, expected_code=200) -> str:
if self.error_message:
return self.error_message
if self.status_code != expected_code:
return FAULT_MAPPING.get("api_request_has_failed").format(status_code=self.status_code)
return ""


class APIClient:
"""
Expand Down
Loading
Loading