deprecate: dynamic import, import.meta, edge polyfills #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the old dynamic import polyfill that only applies for Safari 10 and Firefox 60 - 66, effectively removing these supports from the polyfill as a deferred v2 deprecation while v2 is still being stabilized.
Since all environments that support dynamic import also support import meta, we also remove this check as well.
In addition an old import fix for edge is also removed, and some remaining async resolver paths are removed as well, making this a net deletion.
Various other refactorings include reducing the mutation observer overhead, better supporting the second argument to import, and removing some unnecessary feature detection.