Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links to other markdown pages #379

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

niloc132
Copy link
Member

Does not fix release notes, javadocs, nor any external links.

Does not fix release notes, javadocs, nor any external links.
Copy link
Member Author

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR aims to help get us to the point of having all working links on the site, so that we can set up a PR check that validates internal links and nightly job for reporting broken external links.

@@ -1,7 +1,7 @@
Getting Started
===

Starting with 2.11.0 of the GWT SDK the [webAppCreator](gettingstarted-outdated.html) is deprecated. Instead, we will use
Starting with 2.11.0 of the GWT SDK the [webAppCreator](gettingstarted.html) is deprecated. Instead, we will use
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that there is no -outdated file - perhaps there was at one point, but it never merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be an refactoring issue.

@@ -159,4 +159,4 @@ set up Eclipse to use the GWT SDK:
[Set up Eclipse](usingeclipse.html)

If you are going to stick with the command line, check out Speed Tracer and then
head over to [Build a Sample GWT App](doc/latest/tutorial/gettingstarted-v2.html).
head over to [Build a Sample GWT App](doc/latest/tutorial/gettingstarted.html).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the "outdated" file, so I don't feel bad for the moment pointing to an old getting started doc.

That said, we don't have a doc/latest/tutorial/gettingstarted-v2 yet, just the original.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unmerged branch 'getting-started-v2' which is containing the file

@niloc132 niloc132 merged commit 35acbf3 into gwtproject:main Dec 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants