Skip to content

Commit

Permalink
Update JDT
Browse files Browse the repository at this point in the history
Use JDT jars from maven central rather than packaging our own

Fix #10026
  • Loading branch information
vegegoku committed Jan 9, 2025
1 parent b2a37ef commit eef092a
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 4 deletions.
13 changes: 10 additions & 3 deletions dev/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@
<include name="apache/tapestry-util-text-4.0.2.jar"/>
<include name="apache/ant-zipscanner/ant-zipscanner-1.6.5-1-rebased.jar"/>
<include name="colt/colt-1.2.jar"/>
<include name="eclipse/original/org.eclipse.jdt.core-3.32.0.jar"/>
<include name="eclipse/org.eclipse.jdt.core_3.33.0.v20230222-1748.jar"/>
<include name="eclipse/org.eclipse.jdt.core.compiler.batch_3.33.0.v20230218-1114.jar"/>
<include name="objectweb/asm-9.6/asm-9.6.jar"/>
<include name="objectweb/asm-9.6/asm-commons-9.6.jar"/>
<include name="objectweb/asm-9.6/asm-util-9.6.jar"/>
Expand Down Expand Up @@ -125,7 +126,11 @@
<zipfileset src="${gwt.tools.lib}/apache/tapestry-util-text-4.0.2.jar"/>
<zipfileset src="${gwt.tools.lib}/apache/ant-zipscanner/ant-zipscanner-1.6.5-1-rebased.jar"/>
<zipfileset src="${gwt.tools.lib}/colt/colt-1.2.jar"/>
<zipfileset src="${gwt.tools.lib}/eclipse/original/org.eclipse.jdt.core-3.32.0.jar">
<zipfileset src="${gwt.tools.lib}/eclipse/org.eclipse.jdt.core_3.33.0.v20230222-1748.jar">
<exclude name="META-INF/*.RSA"/>
<exclude name="META-INF/*.SF"/>
</zipfileset>
<zipfileset src="${gwt.tools.lib}/eclipse/org.eclipse.jdt.core.compiler.batch_3.33.0.v20230218-1114.jar">
<exclude name="META-INF/*.RSA"/>
<exclude name="META-INF/*.SF"/>
</zipfileset>
Expand Down Expand Up @@ -224,7 +229,9 @@
<pathelement
location="${gwt.tools.lib}/apache/commons/commons-collections-3.2.2.jar"/>
<pathelement
location="${gwt.tools.lib}/eclipse/original/org.eclipse.jdt.core-3.32.0.jar"/>
location="${gwt.tools.lib}/eclipse/org.eclipse.jdt.core_3.33.0.v20230222-1748.jar"/>
<pathelement
location="${gwt.tools.lib}/eclipse/org.eclipse.jdt.core.compiler.batch_3.33.0.v20230218-1114.jar"/>
<pathelement
location="${gwt.tools.lib}/guava/guava-33.0/guava-33.0.0-jre-rebased.jar"/>
<pathelement
Expand Down
2 changes: 1 addition & 1 deletion maven/lib-gwt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function maven-gwt() {

echo "Removing bundled third-parties from gwt-dev"
zip -q $GWT_EXTRACT_DIR/gwt-dev.jar --copy --out $GWT_EXTRACT_DIR/gwt-dev-trimmed.jar \
"com/google/gwt/*" "org/eclipse/jdt/*"
"com/google/gwt/*"
mv $GWT_EXTRACT_DIR/gwt-dev-trimmed.jar $GWT_EXTRACT_DIR/gwt-dev.jar
echo "Removing bundled third-parties from gwt-user"
zip -q $GWT_EXTRACT_DIR/gwt-user.jar --copy --out $GWT_EXTRACT_DIR/gwt-user-trimmed.jar \
Expand Down
4 changes: 4 additions & 0 deletions maven/poms/gwt/gwt-dev/pom-template.xml
Original file line number Diff line number Diff line change
Expand Up @@ -114,5 +114,9 @@
<groupId>org.eclipse.jetty</groupId>
<artifactId>apache-jsp</artifactId>
</dependency>
<dependency>
<groupId>org.eclipse.jdt</groupId>
<artifactId>org.eclipse.jdt.core</artifactId>
</dependency>
</dependencies>
</project>
6 changes: 6 additions & 0 deletions maven/poms/gwt/pom-template.xml
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,12 @@
<artifactId>jetty-xml</artifactId>
<version>${jetty.version}</version>
</dependency>
<!-- https://mvnrepository.com/artifact/org.eclipse.jdt/org.eclipse.jdt.core -->
<dependency>
<groupId>org.eclipse.jdt</groupId>
<artifactId>org.eclipse.jdt.core</artifactId>
<version>3.33.0</version>
</dependency>
</dependencies>
</dependencyManagement>
</project>

0 comments on commit eef092a

Please sign in to comment.