Fix raw norm#156
Open
tomo-oga wants to merge 3 commits into
Open
Conversation
Member
|
Thanks this looks good. In fact, I changed this to remove the original normalized check which doesn't make sense. However, given this change, we would want to look at the stopword list and for many cases add both capitalized and lowercase versions where that makes sense and one is missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When annotating, gilda will reference the ner_stoplist, however this comparison is done with the normalized strings in the text, against non-normalized stopwords in the file, which causes them to be missed. This pull request resolves this by having the unnormalized word be referenced against the stoplist.