Optimize sqlite database size and speed#168
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes optimizations to the sqlite-based back-end for Gilda. The previous approach represented each
norm_textas one row with a list of corresponding JSON-serialized Terms as a single value in another column. This is convenient and maps intuitively to theDict[str, List[Term]]data structure the sqlite adapter stands in for. But all the JSON keys being stored redundantly are taking up a large amount of space.In this PR, the sqlite schema is changed such that we have one row per Term and each Term attribute has its own column. This significantly cuts down on db size (old: 655MB, new: 331MB) and the net speed of retrieval (i.e., norm_text -> list of deserialized Term objects) is also slightly improved.