Skip to content

Add MONDO terms#70

Open
cthoyt wants to merge 3 commits into
masterfrom
add-mondo-terms
Open

Add MONDO terms#70
cthoyt wants to merge 3 commits into
masterfrom
add-mondo-terms

Conversation

@cthoyt
Copy link
Copy Markdown
Contributor

@cthoyt cthoyt commented Nov 2, 2021

Closes #50

This PR adds MONDO using the same interface as for EFO, HP, and other OBO ontologies following the inclusion of the MONDO resource in INDRA in gyorilab/indra#1311.

This PR also bumps the version from 0.7.1 to 0.7.2

@cthoyt cthoyt marked this pull request as ready for review November 2, 2021 22:36
@bgyori
Copy link
Copy Markdown
Member

bgyori commented Nov 2, 2021

Thanks! This looks straightforward, but underneath the hood, I am worried that we are introducing a lot of redundancies between MONDO and other namespaces providing entries for diseases. Unless these are explicitly resolved during term generation, we will end up with suboptimal results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MONDO

2 participants