Implement client for new PMC S3 content access#1500
Open
bgyori wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements new client functions in
indra.literature.pmc_clientto migrate from the soon deprecated FTP-based content access to the new S3-based access (see https://pmc.ncbi.nlm.nih.gov/tools/pmcaws/). Previously, each article had a non-obvious FTP path that had to be looked up in a catalogue based on the PMID or PMC ID and then used to fetch a tar file with the "package" of files corresponding to the article. With S3, there is a fixed access path for a given PMC ID (+ version) and the list and type of files is available via a separate metadata request. The new client functions implement requests to get available (or latest) version, metadata, getter functions for different types of content, and a single function to download all article files into a given folder.