Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path concat in HTTPStore #42

Merged
merged 3 commits into from
Mar 4, 2020
Merged

Fix path concat in HTTPStore #42

merged 3 commits into from
Mar 4, 2020

Conversation

gzuidhof
Copy link
Owner

@gzuidhof gzuidhof commented Mar 3, 2020

Should fix #36

@gzuidhof gzuidhof requested a review from manzt March 3, 2020 18:27
manzt
manzt approved these changes Mar 3, 2020
View reviewed changes
Copy link
Collaborator

@manzt manzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for tackling this!

@gzuidhof gzuidhof merged commit 0d87c27 into master Mar 4, 2020
@gzuidhof gzuidhof deleted the gzuidhof.fix-url-concat-in-httpstore branch March 4, 2020 17:04
@manzt manzt mentioned this pull request Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manzt manzt manzt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better support for hierachrical stores and nested urls
2 participants
@gzuidhof @manzt