Skip to content

Fixes #115#123

Open
denzuko wants to merge 2 commits intoh2oai:mainfrom
denzuko:main
Open

Fixes #115#123
denzuko wants to merge 2 commits intoh2oai:mainfrom
denzuko:main

Conversation

@denzuko
Copy link
Copy Markdown
Contributor

@denzuko denzuko commented Nov 20, 2023

Description:

Related Issues (optional):

Changes:
  - amends line 20 to make clear that windows also works with the same commands
Changes
  - Implements issue h2oai#115 suggestion for improved verbage.
@mturoci
Copy link
Copy Markdown
Collaborator

mturoci commented Nov 20, 2023

#115 needs Windows instructions. WSL is just Linux on Windows which we already have. We need native Windows steps.

@denzuko
Copy link
Copy Markdown
Contributor Author

denzuko commented Nov 20, 2023

@mturoci how native do we need? I'm using chocolatey right now to install python within Windows Terminal but are we meaning from bare bones click ops (e.g. download python installer from python.org, download zipfile of wave-apps from github, unzip via windows explorer, >> open terminal here, ...)?

@mturoci
Copy link
Copy Markdown
Collaborator

mturoci commented Nov 20, 2023

@denzuko this repo serves mostly AI/DS people who are not "true software engineers" so the simpler we can make it for them the better.

While I like chocolatey, I doubt that majority of "regular" people use it. Based on the docker docs, the installation should be as simple as installing docker-desktop, running it and that should automatically start docker daemon (same as MacOS) which in theory should make all the actual commands we currently have work out of the box.

Now, all of the above ^^ is just a speculation and needs verification. All the help is more than welcome.

TLDR: Link to docker in installation docs, verify all the commands we have work on Windows. If they do, remove MacOS / Linux description in the README and we are good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants